From 526d54670e70c3bd18dbde4307490cf1121bf699 Mon Sep 17 00:00:00 2001
From: shinjaehyeok <shinjaehyeok@gmail.com>
Date: Sat, 7 Sep 2024 11:45:53 -0700
Subject: [PATCH] Add an unit test for GLRCU - Bernoulli class

---
 R/stcp.R                     |  2 ++
 tests/testthat/test-glrcu.R  | 63 ++++++++++++++++++++++++++++++++++++
 tests/testthat/test-sr_ber.R |  0
 3 files changed, 65 insertions(+)
 create mode 100644 tests/testthat/test-glrcu.R
 delete mode 100644 tests/testthat/test-sr_ber.R

diff --git a/R/stcp.R b/R/stcp.R
index fff6bbd..d1ae8de 100644
--- a/R/stcp.R
+++ b/R/stcp.R
@@ -176,6 +176,8 @@ Stcp <- R6::R6Class(
         }
         
         # Check delta_lower is within boundary for Ber and Bounded cases
+        # For Ber, post-change parameter must be strictly within (0,1)
+        # For Bounded case, post-change parameter can include 0 or 1.
         if (family == "Ber") {
           if (alternative != "less") {
             if (m_pre + delta_lower >= 1) {
diff --git a/tests/testthat/test-glrcu.R b/tests/testthat/test-glrcu.R
new file mode 100644
index 0000000..746d211
--- /dev/null
+++ b/tests/testthat/test-glrcu.R
@@ -0,0 +1,63 @@
+test_that("GLRCU - Bernoulli run as same as the hard-coded R function", {
+  # Config
+  p_pre <- 0.3 # H0: p = 0.3 H1: p != 0.3
+  max_sample <- 1000L
+  ARL_target <- max_sample * 0.5
+
+  # Hard-coded GLRCU Bernoulli for "two.sided" alternative
+  # We return the entire run history for a test
+  glrcuBerRwithHistory <- function(x_vec, p_pre, thres, window_size = length(x_vec)) {
+    n_max <- length(x_vec)
+    n_star <- Inf
+    m <- -Inf
+    p_lower <- 1e-5
+    p_upper <- 1 - p_lower
+    p_hat <- 0.5
+    m_vec <- length(n_max)
+    p_hat_vec <- length(n_max)
+    for (i in 1:n_max) {
+      for (j in 1:i) {
+        n_inner <- i - j + 1
+        s <- sum(x_vec[j:i])
+        f <- n_inner - s
+        # For simplicity, we use a soft cap around boundary
+        # which is slightly different from a formal Stcp implementation
+        p_hat_inner <- min(max(s/n_inner, p_lower), p_upper)
+        m_inner <-
+          s * log(p_hat_inner/p_pre) + f * log((1-p_hat_inner)/(1-p_pre))
+        if (m < m_inner) {
+          m <- m_inner
+          p_hat <- p_hat_inner
+        }
+      }
+      m_vec[i] <- m
+      p_hat_vec[i] <- p_hat
+      if (m > thres) {
+        n_star <- i
+      }
+      m <- -Inf
+    }
+    return(list(n_star = n_star, m_vec = m_vec, p_hat_vec = p_hat_vec))
+  }
+  
+  # stcpR6 implementation
+  glrcuBerStcp <- stcpR6::Stcp$new(
+    method = "GLRCU",
+    family = "Ber",
+    alternative = "two.sided",
+    threshold = log(ARL_target),
+    m_pre = p_pre
+  )
+  
+  # Test sample
+  x_vec <- rbinom(max_sample, 1, p_pre)
+  
+  # Runs
+  glr_R_out <- glrcuBerRwithHistory(x_vec, p_pre, thres = log(ARL_target))
+  
+  glr_Stcp_out <- glrcuBerStcp$updateAndReturnHistories(x_vec)
+
+  # Two runs are expected to be almost equal to each other
+  # Slight difference comes from p_hat implementation detail
+  expect_true(mean(abs(glr_R_out$m_vec - glr_Stcp_out)) < 1e-4)
+})
\ No newline at end of file
diff --git a/tests/testthat/test-sr_ber.R b/tests/testthat/test-sr_ber.R
deleted file mode 100644
index e69de29..0000000