Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primehack crashes when adding a default path #169

Open
hikagura99 opened this issue Jul 4, 2024 · 2 comments
Open

Primehack crashes when adding a default path #169

hikagura99 opened this issue Jul 4, 2024 · 2 comments

Comments

@hikagura99
Copy link

hikagura99 commented Jul 4, 2024

Whenever i try to add a default rom path to the list, it crashes and when relaunched it didn't save the setting. This happens only on primehack, standard dolphin is not having any problem. This happens both when adding it with a double click from the starting screen and when adding it from the configuration settings. It crashes only after it has been selected, not before or after opening the file explorer.
I'm running it on an HP 255 G8 with Arch Linux, Zen Kernel 6.9.7 with KDE Plasma 6 on a Wayland Session as a DE (obviously with the QT_QPA_PLATFORM=xcb environment variable)

Edit: sorry for all the edits for a moment i thought to have issued this on the official dolphin github page lol

@hikagura99 hikagura99 changed the title Primehack crashes when adding a default path my mistake do not open this Jul 4, 2024
@hikagura99 hikagura99 changed the title my mistake do not open this Primehack crashes when adding a default path Jul 4, 2024
@hikagura99 hikagura99 reopened this Jul 4, 2024
@SirMangler
Copy link
Collaborator

How did you install PrimeHack? Was it the Flatpak, AUR or did you compile it yourself? As far as I'm aware the AUR has some patches that change stuff related to the paths. It may be worth double checking with the flatpak to see if it's an issue with us. I would also recommend clearing your ini settings just in case something odd has happened there.

@xiota
Copy link

xiota commented Oct 28, 2024

AUR package is rebased to more recent Dolphin commit, so can have different problems.

The problem is fixed in upstream Dolphin at dolphin-emu@6245dcd

The corresponding lines in this repo are:

DecompressionBuffer in{std::vector<u8>(bytes_to_move), bytes_to_move};
std::memcpy(in.data.data(), m_out.data.data() + m_out_bytes_used_for_exceptions, bytes_to_move);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants