Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin still runs when toggled in community plugins #8

Open
Aaron-Bopp opened this issue Oct 30, 2021 · 2 comments
Open

Plugin still runs when toggled in community plugins #8

Aaron-Bopp opened this issue Oct 30, 2021 · 2 comments

Comments

@Aaron-Bopp
Copy link

It seems if you have this on and then toggle it off, it will continue to run until you close and reopen obsidian

@rzfzr
Copy link

rzfzr commented Dec 31, 2021

I notice this kind of thing in other plugins/settings, it is an obsidian issue on applying changes.
On the commands list you can select Reload app or even add it to an hotkey.

@pjeby
Copy link

pjeby commented Mar 31, 2024

It's not an issue with Obsidian, it's an issue with the plugin not calling this.registerEvent() on the return value of its this.workspace.on() calls. So when the plugin is disabled, it's not deactivating the handling for those events. If there are other plugins that don't properly deactivate when you disable them, they're probably broken in a similar way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants