Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace geocoder 0.2.2 with node-geocoder latest #73

Open
lc-101 opened this issue Jan 11, 2019 · 1 comment
Open

Replace geocoder 0.2.2 with node-geocoder latest #73

lc-101 opened this issue Jan 11, 2019 · 1 comment

Comments

@lc-101
Copy link

lc-101 commented Jan 11, 2019

It seems this lib is using geocoder version 0.2.2. Unfortunately when google started requiring users to use an API key for their geocoder API, all functions in the lib that relayed on geocoder stopped working. I do see #24 where it seems node-geocoder was going to be added to the project, looking at the commit history I only ever see geocoder as being part of the project. It seems that we would need to replace geocoder with node-geocoder and add methods to pass API keys to the lib.

Thoughts?

@dorshay6
Copy link
Contributor

@lc-101 Created PR but I have issues with test on my env.
Looks like its working :)
#74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants