Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treesitter support in vim-nord -- link FYI #3

Closed
kierun opened this issue May 17, 2021 · 8 comments
Closed

Treesitter support in vim-nord -- link FYI #3

kierun opened this issue May 17, 2021 · 8 comments
Labels
documentation Improvements or additions to documentation wontfix This will not be worked on

Comments

@kierun
Copy link

kierun commented May 17, 2021

Nord has an issue/PR for tree sitter support.

This might be of interest and I have linked this repo to the issue there.

Feel free to close this if it is of no interest. ^_^

@shaunsingh
Copy link
Owner

Thanks for bringing that to my attention! Nice to see tree sitter being integrated into the main color-scheme. For now I will leave the issue open

The biggest issue is that Nord.nvim isn't backwards compatible with vim8, since it's written in lua. For now I've opened this issue in the main repository,nordtheme/nord#157

@kierun
Copy link
Author

kierun commented May 17, 2021

You are most welcome! 😀 Thank you for doing this. I'll install it when I have some time -- then, I will need to figure out how to change the background to black and keep the rest the same. 👍

@shaunsingh
Copy link
Owner

Thanks for the feedback! If you would like to change the background to black, you can fork the repository, then go to this file: https://github.com/shaunsingh/nord.nvim/blob/master/lua/nord/colors.lua, and edit the bg and bg_alt colors to match your taste

Enjoy!

@kierun
Copy link
Author

kierun commented May 17, 2021

Thank you! I might just have a branch and keep your changes merged in whenever Plug updates.

How hard would it be to add a option in vimrc? Never done it but always willing to learn ^_-

@shaunsingh
Copy link
Owner

Would that be an option to switch between branches with vim-plug, or an option to change the background color?

A Background color switch would be a quick easy addition to the theme, but I would prefer not to add it on the main branch since I personally feel change the background color detracts from the feel of the theme.

@kierun
Copy link
Author

kierun commented May 17, 2021

A Background color switch would be a quick easy addition to the theme, but I would prefer not to add it on the main branch since I personally feel change the background color detracts from the feel of the theme.

This one. And it is a very reasonable thing to do! 👍 Thank you.

@shaunsingh shaunsingh added documentation Improvements or additions to documentation wontfix This will not be worked on labels May 18, 2021
@shaunsingh
Copy link
Owner

I talked a tad bit with articicestudios about adding the nord theme or improving treesitter support, I'll go from there. Thanks once again for bringing this to my attention!

@kierun
Copy link
Author

kierun commented Jul 12, 2021

You are most welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants