Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split sqlalchemy_url into separate settings #59

Open
akurdyukov opened this issue Nov 3, 2023 · 1 comment · May be fixed by #104
Open

Split sqlalchemy_url into separate settings #59

akurdyukov opened this issue Nov 3, 2023 · 1 comment · May be fixed by #104

Comments

@akurdyukov
Copy link
Contributor

Currently loader has only one setting sqlalchemy_url with is not convenient in cases:

  1. hiding password as secret type of setting
  2. plugin config inheritance inmeltano.yml

What do you think of breaking change like this?

    config_jsonschema = th.PropertiesList(
        th.Property(
            "driver",
            th.StringType,
            required=False,
            description="Driver type",
            default="http",
            allowed_values=["http", "native", "asynch"]
        ),
        th.Property(
            "username",
            th.StringType,
            required=False,
            description="Database user",
            default="default",
        ),
        th.Property(
            "password",
            th.StringType,
            required=True,
            description="Username password",
            secret=True
        ),
        th.Property(
            "host",
            th.StringType,
            required=False,
            description="Database host",
            default="localhost"
        ),
        th.Property(
            "port",
            th.IntegerType,
            required=False,
            description="Database connection port",
            default=8123,
        ),
        th.Property(
            "database",
            th.StringType,
            required=False,
            description="Database name",
            default="default",
        ),
        th.Property(
            "secure",
            th.BooleanType,
            description="Should the connection be secure",
            default=False
        ),
        th.Property(
            "verify",
            th.BooleanType,
            description="Should secure connection need to verify SSL/TLS",
            default=True
        ),
    ).to_dict()
@BTheunissen
Copy link
Contributor

Does this need to be a breaking change, could we instead provide both configuration options?

@akurdyukov akurdyukov linked a pull request Jan 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants