Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes fails to detect video elements #29

Open
joeyparrish opened this issue Jan 13, 2022 · 0 comments
Open

Sometimes fails to detect video elements #29

joeyparrish opened this issue Jan 13, 2022 · 0 comments
Labels
priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Milestone

Comments

@joeyparrish
Copy link
Member

In some cases, the code to detect video elements seems to fail. It should work like this:

  1. Query the document for all existing video elements (synchronous, in _traceExistingElements)
  2. Listen for DOM mutations to catch future video elements (in _setupNewElementObserver)

Somehow, there is a hole in this that allows some video elements to escape notice some of the time. On some pages, reloading a few times will eventually make it work again.

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Jan 13, 2022
@github-actions github-actions bot added this to the Backlog milestone Feb 24, 2022
@joeyparrish joeyparrish added the priority: P2 Smaller impact or easy workaround label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

1 participant