semaphore: Use handles to properly handle semaphore double-delete. #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squidbus
force-pushed
the
sema-handle
branch
from
7eb8fc2 to
6f63927
Compare
rainmakerv3
pushed a commit
to rainmakerv3/shadPS4
that referenced
this pull request
Dec 10, 2024
MajorP93
added a commit
to MajorP93/shadPS4
that referenced
this pull request
Dec 10, 2024
…lete. (shadps4-emu#1728)" This reverts commit 41fd1c8.
Xcedf
pushed a commit
to Xcedf/shadPS4
that referenced
this pull request
Dec 10, 2024
diegolix29
pushed a commit
to diegolix29/shadPS4
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to storing semaphores in a
SlotVectorand using handles instead of pointers, so that we can properly determine if a semaphore has been deleted or not and prevent double-deletes or use-after-frees.