thread: Apply alternate signal stack to created threads. #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoquang2708
pushed a commit
to ngoquang2708/shadPS4
that referenced
this pull request
Dec 10, 2024
rainmakerv3
pushed a commit
to rainmakerv3/shadPS4
that referenced
this pull request
Dec 10, 2024
/build/shadps4-git/src/shadps4/src/core/thread.cpp:
In member function ‘void Core::NativeThread::Initialize()’:
/build/shadps4-git/src/shadps4/src/core/thread.cpp:147:5:
error: designator order for field ‘stack_t::ss_flags’ does not match declaration order in ‘const stack_t’Fails to build on Arch Linux... I do have an extra patch with 1683 changes in there but those have nothing to do with threads it seems... EDIT: so 1683 got merged as I was trying this, will retry master without patches just in case, but still doubt it was the issue. EDIT2: Still an issue. EDIT3: I think I fixed it? Will send a PR if the build passes... |
diegolix29
pushed a commit
to diegolix29/shadPS4
that referenced
this pull request
Dec 10, 2024
MajorP93
added a commit
to MajorP93/shadPS4
that referenced
this pull request
Dec 10, 2024
…dps4-emu#1724)" This reverts commit cd9fc5d.
diegolix29
pushed a commit
to diegolix29/shadPS4
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With guest stacks in place, if the guest asks for a very small stack size we may overflow the stack in our signal handling. Notably this can happen to more threads on macOS, since we use signal handlers more heavily for patching a few instructions not supported by Rosetta 2.
To solve this, apply an alternate signal stack to each thread created. When signal handlers execute they will switch to this alternate stack instead of executing on the thread stack.
Fixes crashes launching CUSA04551 (NieR:Automata) on macOS, probably helps Linux and some other games as well.