fix: fix #1457 again by moving av_err2str to a common header #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainmakerv3
pushed a commit
to rainmakerv3/shadPS4
that referenced
this pull request
Dec 8, 2024
Xcedf
added a commit
to Xcedf/shadPS4
that referenced
this pull request
Dec 9, 2024
…mon header (shadps4-emu#1688)" This reverts commit dad5953. Revert "hot-fix: Allow unpriviledged userfaultfd" This reverts commit 8ee672f. Revert "shader_recompiler: Fix mistake" This reverts commit cde84e4.
Xcedf
pushed a commit
to Xcedf/shadPS4
that referenced
this pull request
Dec 10, 2024
Xcedf
pushed a commit
to Xcedf/shadPS4
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the regression of #1457 happening a second time, I suggest moving the macro redefinition to a separate header so maintenance and remediation is easier to deal with as the macro will now exist in four distinct places.
Place relocate
common/support/avdec.hif needed.