-
-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: added status column for compat data #1668
base: main
Are you sure you want to change the base?
Conversation
* data is currently pulled directly from github API, awaiting server infra
793f7a7
to
acdd3be
Compare
Wonderful.
All of this are suggestion as the PR is in draft |
Hey I opened a PR on your fork fixing the linker error |
Great ideas -example of the second column in two versions |
When I started, I got a window, but it hung? Progress just stopped. How long do I have to wait? Although I was glad to see the update of this PR, but after some thought about it, @DanielSvoboda As you know, we have the ability to update the emulator manually, there are even two ways to do this. We also don't have the ability to move columns in places, but I'd like to see what such a sequence would look like, would it be better?.. |
I think you're running into github API's limits. If you run the emulator normally this error shouldn't occur as the data is saved to a json and only updated after an hour. In any case there's no need to fix it as it seems there will be a compatibility database on shadps4's website which will remove the need for that part of the code. |
@f8ith the fact is that I start the emulator, a window appears, in seconds it reaches a certain progress and freezes, if I close this window (do not cancel) by interrupting this progress, then I will not have a JSON file. And so I wanted to record it on video, but apparently an hour later (as you said), the database was updated and I got this file (compatibility_data.json). |
When I was doing AutoUpdate, I noticed that the GitHub APIs can only make 60 requests in a one-hour period. If you exceed this limit, these requests will be blocked for a while. You have to be careful not to have too many requests. |
2 suggestions:
|
As I suggested above, you can do this:
It turns out that the general part will be a link to which the serial number is appended, if such a thing can be done at all.
|
Yes, exactly @GHU7924 For the 1: On the serial is a good idea. Maybe add something like an icon "click" to know that we can open it |
@Hermiten Like this? |
@Hermiten Verification may not be necessary, because when you click, you will be redirected to a page where you can view the report. Now: If there is no report, then there is no link and it will be written that the game has not been tested. What can be done: This is where your idea may come in handy, and when you click on the status of the game, you will be prompted to create a report. You can add information that the game has not been tested, but if you click on the status, you can create a report. @f8ith If you are going to create a report, then remember that we have a form to fill out. |
Can you solve the clang format ? And then we will do some final test :) |
Addresses #1571
WIP PR intended to gather opinions about how the status column should behave. In my implementation a dialog appears by default on startup while the emulator fetches compatibility information. The database is saved to a single json under the
game_data
folder. Then the best available status is selected based on the current platform.e.g. on Windows (os-windows -> no os label -> os-linux -> os-macOS)
Edit: Latest commit