Support for Vulkan 1.4 #1665
Support for Vulkan 1.4 #1665
Conversation
|
Unless we actually use vulkan 1.4, I don't think updating find_package is a good idea, as it will prevent some linux distros that are not cutting edge from using system headers. @abouvier probably knows more on this subject |
|
Hardware requirements gonna be raised? What GPU now we should have? |
|
This doesn't raise minimum vulkan version emulator requires (that will still be 1.2), but rather updates library headers to allow emulator to use vulkan 1.4 in the future. In summary this is mostly on cosmetic side so not much to worry about |
externals/CMakeLists.txt
Outdated
| @@ -123,6 +123,7 @@ endif() | |||
| # MagicEnum | |||
| if (NOT TARGET magic_enum::magic_enum) | |||
| add_subdirectory(magic_enum) | |||
| target_include_directories(magic_enum INTERFACE magic_enum/include/magic_enum) | |||
There was a problem hiding this comment.
Headers are now installed in /usr/include/magic_enum/magic_enum.hpp. You should edit all *.cpp files, replacing #include <magic_enum.hpp> with #include <magic_enum/magic_enum.hpp> instead. Using system magic_enum lib will fail otherwise.
It's fine, old distros will fallback on external headers. Otherwise, without the source code change, it's the rolling distros that will not be able to compile with the latest system headers. Newer distros should be privileged :) |
|
I have made the requested changes! |
|
@raphaelthegreat Any news? The changes that were requested have been applied and approved. |
|
Yes it looks okay now, thanks for the upgrade |
|
Oops, you should have raised the version constraint of |
This reverts commit 119e03c. Revert "shader_recompiler: Implement V_LSHL_B64 for immediate arguments. (shadps4-emu#1674)" This reverts commit c076ba6. Revert "Fix + documentation update (shadps4-emu#1689)" This reverts commit 57e7624. Revert "Support for Vulkan 1.4 (shadps4-emu#1665)" This reverts commit 2266622.
Added support for Vulkan 1.4
Interesting article: https://www.khronos.org/news/press/khronos-streamlines-development-and-deployment-of-gpu-accelerated-applications-with-vulkan-1.4