Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vercel for snapshot / pr previews? #6

Open
bhajneet opened this issue Jun 5, 2020 · 8 comments
Open

Use vercel for snapshot / pr previews? #6

bhajneet opened this issue Jun 5, 2020 · 8 comments
Labels
? Type Question User/developer question.

Comments

@bhajneet
Copy link
Member

bhajneet commented Jun 5, 2020

Something like this: https://shabad-os-theme-tool-3m9jkes5d.now.sh/

From: https://vercel.com/

@bhajneet bhajneet added the ? Type Question User/developer question. label Jun 5, 2020
@saihaj
Copy link
Member

saihaj commented Jun 8, 2020

It is also possible using gh-pages if we don't want to go on some third-party platform. Check out this PR and they are trying to implement using gh-actions primer/react#820

@Harjot1Singh
Copy link
Member

Main constraint is being able to deploy multiple branches. Vercel is great, shame it's only frontend. Would work for us though.

@saihaj
Copy link
Member

saihaj commented Jun 22, 2020

If we can use vm’s then we can setup a dockerized preview https://nebulab.it/blog/preview-your-prs-with-docker/ then we can do frontend and backend

@saihaj
Copy link
Member

saihaj commented Jul 3, 2020

Vercel is great, shame it's only frontend. Would work for us though.

We can deploy backend too if we make it work serverless. Something like https://www.prisma.io for db connection. Other option can be if we get our api out and add support in desktop.

@Harjot1Singh
Copy link
Member

@Harjot1Singh
Copy link
Member

Did some in-depth reading. Adapting this looks like a solid bet: https://okteto.com/docs/tutorials/preview-environments/index.html.

I'm tempted to suggest setting up a k8s.preview.yml in each repository we want a preview for, with the definitions for running the preview.

Once the action is run. it'd produce a url like: https://${{ github.event.repository.name }}-[${{ github.event.number }}].preview.shabados.com.

And delete whatever has been spun up on the close pull request event.

@Harjot1Singh
Copy link
Member

Should we be able to download existing k8s configs and replace some values (in a pre-action to this)?

E.g. Viewer has a manifest already, and we'd be duplicating it entirely with a preview, but presenter does not.

Perhaps it's better to just duplicate it for now, since we only have 1 case of this currently.

@Harjot1Singh
Copy link
Member

There is also an option to use Pull Dog!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? Type Question User/developer question.
Projects
Status: Triage
Development

No branches or pull requests

3 participants