Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Danger Rules #1

Open
Harjot1Singh opened this issue May 11, 2020 · 2 comments
Open

Danger Rules #1

Harjot1Singh opened this issue May 11, 2020 · 2 comments

Comments

@Harjot1Singh
Copy link
Member

No description provided.

@Harjot1Singh Slack
Copy link
Member Author

Harjot1Singh commented May 11, 2020 •
edited
Loading

Did you save this somewhere? Danger JS

  • Comment failing unit tests
  • Comment failing lint
  • Comment SemVer bump of PR
  • Check SemVer bump of PR
    • If major, require a changelog edit
    • If minor/patch, warn for a missing changelog edit ("Does it affect user interaction/experience?" then make a changelog edit)
  • Warn/Require lockfile being up to date?
  • Warn if PR is not assigned to someone for review
  • Require PR is linked to 3 or less issues
  • Warn if PR is linked to 2 or 3 issues
  • Warn if PR is not linked to any issues
  • Require testing when it should
  • If testing is required, then documentation probably is too
  • Descriptiveness of PR titles, especially if stale
  • Time elapsed since first commit of PR
    View in Slack

@Harjot1Singh Harjot1Singh mentioned this issue Nov 5, 2020
Open
@saihaj
Copy link
Member

saihaj commented Feb 21, 2021

Once I figure out how to get danger and GH actions secrets to work with forks I can take this. https://spectrum.chat/danger/javascript/having-issues-to-get-danger-to-work-with-gh-actions~6dbe81db-44f7-49cf-9eea-4cb611170c9e?m=MTYxMzg3NTc0NjYzNg==

@saihaj saihaj moved this to Triage in Project Management Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Project Management
Status: Triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Harjot1Singh @saihaj