Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified 2.5D WFS Framework #136

Open
fs446 opened this issue Mar 31, 2017 · 8 comments
Open

Unified 2.5D WFS Framework #136

fs446 opened this issue Mar 31, 2017 · 8 comments
Assignees

Comments

@fs446
Copy link
Member

fs446 commented Mar 31, 2017

We might add the driving functions of plane wave, point/line source of the unified 2.5D WFS framework for different referencing schemes / positions of amplitude correct synthesis (PCS) into the toolbox based on the findings
https://doi.org/10.1109/TASLP.2017.2689245
, see also
142nd Audio Eng. Soc. Conv, Berlin, #9722
for general vector notation of these driving functions. Then, 'only' the referencing function must be adapted to work in general vector notation for desired reference curves.

@hagenw
Copy link
Member

hagenw commented Apr 4, 2017

Nice idea.
@fs446 or @gfirtha do you have time to create a small first pull request with an example implementation, or should I have a try at it?

@fs446
Copy link
Member Author

fs446 commented Apr 4, 2017 via email

@fs446
Copy link
Member Author

fs446 commented Apr 18, 2017

init dev in branch 'unified_25d_wfs'

@fs446
Copy link
Member Author

fs446 commented Apr 18, 2017

[D, xPCS] = driving_function_mono_unified_25d_wfs(x0,xs,dx0,src,f,conf) is working as expected with the current state dab14a1
Fig. 3,4,9,10 from https://doi.org/10.1109/TASLP.2017.2689245 created with this one->ok

Now we need a meaningful implementation for defining a referencing function somewhere outside the calculation of the sound field with sound_field_mono_wfs(X,Y,Z,xs,src,f,conf). A further input parameter could do this. Any ideas, how we should proceed to be most consistent with the current toolbox handling.

@fs446
Copy link
Member Author

fs446 commented Apr 18, 2017

added a test script in 916fc76 that checks the driving functions.

@hagenw
Copy link
Member

hagenw commented Apr 21, 2017

Cool, thanks for your effort. I will have a look at this next week.

@hagenw
Copy link
Member

hagenw commented May 5, 2017

The driving functions look ok, but I think I would integrate them under the 2.5D parts of the virtual source type driving functions we have at the moment, see the point source example. This is something I could do easily.

If I understand it correctly, the reference line/point is defined by the dx0 amplitude values you have to provide for every source. Is there a more user friendly way to get this done? It is good that the user would have the possibility to define whatever she/he want, but it would also be great if for simple cases like a point or a line parallel to the secondary sources the calculation would work automatically.

@fs446
Copy link
Member Author

fs446 commented May 5, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants