Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waveforms Should Be URLs #508

Open
danpastori opened this issue May 4, 2022 Discussed in #507 · 0 comments · May be fixed by #514
Open

Waveforms Should Be URLs #508

danpastori opened this issue May 4, 2022 Discussed in #507 · 0 comments · May be fixed by #514
Assignees
Labels

Comments

@danpastori
Copy link
Contributor

Discussed in #507

Originally posted by danpastori May 4, 2022

👉 Describe the problem

When generating a waveform, the audio file is loaded twice or is only loaded up to what is buffered. This leads to terrible UI since it's either two requests, or partially shown.

👥 Problem evidence & reach

Any user working with waveforms.

🥰 Describe the "impact" on users?

When displaying a waveform, we should allow the user to pass in a URL. We can generate waveforms using Amplitude Hosting and these will be SVGs making for much speedier, responsive players.

🏆 How to solve this problem

Allow for a waveform to be a URL for the audio file and encourage this. We will remove all waveform generating functionality and abstract it to a plugin. This will be a breaking change, but will lead to much cleaner code, smaller compiled sizes, and better UX.

💯 How do we validate the problem is solved?

A user can generate a waveform through Amplitude Hosting or their own provider and pass it along with an audio file so it loads instantly.

@danpastori danpastori added the Enhancement ⚡️ New feature label May 4, 2022
@danpastori danpastori self-assigned this May 4, 2022
@danpastori danpastori moved this to Ready for Development in AmplitudeJS 6.0 May 4, 2022
@danpastori danpastori linked a pull request Jun 3, 2022 that will close this issue
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for Development
Development

Successfully merging a pull request may close this issue.

1 participant