blockpage = about:blank is not persisted

[orbitalchicken]

When I set the blockpage to "about:blank", it work only in the current browser session.
When I close the browser and restart it, the blockpage has reset to "undefinied".
"about:blank" should be persisted.
(PS: about:blank shows a white page)

[serv-inc]

Hopefully fixed in 1.4.1. It's great that you reported this.

[orbitalchicken]

Still not working. Tested with 1.4.1.

[serv-inc]

Which OS (and version of FireFox) did this occur on?

(it worked on Linux for Chrome 68.0.3440.75, Firefox default/RR and Firefox ESR)

[orbitalchicken]

Linux Le 2018-08-13 à 09:29, serv-inc a écrit :

…

Which OS are you using? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIrg8T5AHBPC4utnloy3gFA3bYY5iH1lks5uQX82gaJpZM4V57nr>.

[serv-inc]

It should work if you reinstall the addon. Would that be acceptable, or not?

[orbitalchicken]

I found that the settings (whitelist and blockpage) are persisted in Firefox but not in Waterfox.
But I remember that in a previous version (1.2, I think), it was working (at least for the whitelist). Did you change the library of framework for the persistance ?

[serv-inc]

It just worked for me with the latest Waterfox. Could you try installing into another profile, as described at https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles?

[orbitalchicken]

I found a hint: Same problem in firefox: If a previous version of the add-ons was already existing, even after I remove and re-install the add-on the blockpage is not persisted. BUT! The field was never added to the storage.js file in ./browser-extension-data/@wsf so I edited the file by hand and added the field "blockpage":"about:blank" at the beginning of the json, than it was persisted between any changes in the add-on page and also between browser restarts. It's seams that the save button in the add-on page just update the field in the json if it exist. If not, it does not create the new field.

[serv-inc]

Would be fixed by #5