Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISA Levels: Add /proc/cpuinfo files for different CPUs and set up test cases #9

Open
16 of 25 tasks
ermo opened this issue Dec 2, 2022 · 4 comments
Open
16 of 25 tasks
Assignees

Comments

@ermo
Copy link
Member

ermo commented Dec 2, 2022

It is probably wise to build a high degree of confidence via tests, as correct /proc/cpuinfo parsing of the ISA levels of different CPUs lie at the core of our Smart System Management promises re. auto-installing faster binaries on systems that support it.

Suggested test cases:

AMD:

  • AMD Phenom II (1090T) (should be -v1)
  • AMD Piledriver (FX-8350) (should be -v2)
  • AMD (... other Bulldozer-derived generations ...)
  • AMD Zen (R7 1700) (should be be -v3x)
  • AMD Zen+ (R7 2700X) (should be -v3x)
  • AMD Zen2 (R9 3900X) (should be -v3x)
  • AMD Zen3 (R9 5900X) (should be -v3x)
  • AMD Zen4 (R7 7700X) (should be -v3x)

Intel:

  • Intel Yorkfield (Q9400) (should be -v1)
  • Intel Atom (?) (should all be -v2)
  • Intel Nehalem (?) (should be -v2)
  • Intel Westmere (?) (should be -v2)
  • Intel Sandy Bridge (ix-2xxx) (should be -v2)
  • Intel Ivy Bridge (ix-3xxx) (should be -v2)
  • Intel Haswell (ix-4xxx) (should be -v3x)
  • Intel Broadwell (ix-5xxx) (should be -v3x)
  • Intel Skylake (ix-6xxx) (should be -v3x)
  • Intel Core 7th gen (should be -v3x)
  • Intel Core 8th gen (should be -v3x)
  • Intel Core 9th gen (should be -v3x)
  • Intel Core 10th gen (should be -v3x)
  • Intel Core 11th gen (should be -v3x)
  • Intel Core 12th gen (should be -v3x)
  • Intel Core 13th gen (should be -v3x)
@ermo ermo self-assigned this Dec 2, 2022
@hype3
Copy link
Contributor

hype3 commented Feb 14, 2023

Hi. I have AMD 2700X (Zen+) Do you want a textfile with the info from /proc/cpuinfo?

@ermo
Copy link
Member Author

ermo commented Feb 14, 2023

Hi. I have AMD 2700X (Zen+) Do you want a textfile with the info from /proc/cpuinfo?

If you could do a PR where you add it as a text file and add the corresponding test case yourself, that'd be preferred?

It should be pretty self-evident how to do it if you look at e.g. https://github.com/serpent-os/moss-core/commit/474f2a4ee344ff2e0aacb79f765075cbf53b4f8c

@hype3
Copy link
Contributor

hype3 commented Feb 14, 2023

I created a PR now... I hope that i did it right as it is along time since i did a PR.

@ermo
Copy link
Member Author

ermo commented Feb 14, 2023

I created a PR now... I hope that i did it right as it is along time since i did a PR.

See the PR for my comments. =)

@ikeycode ikeycode transferred this issue from another repository Mar 21, 2023
@ermo ermo added the moss-core label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants