Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's make fetch success/error/etc not depend on HTTP status codes? #8

Open
ermo opened this issue Jan 18, 2023 · 0 comments
Open

Let's make fetch success/error/etc not depend on HTTP status codes? #8

ermo opened this issue Jan 18, 2023 · 0 comments

Comments

@ermo
Copy link
Member

ermo commented Jan 18, 2023

From an abstract point of view, we're interested in whether a download succeeded or not and what the reason was if it didn't succeed.

The current design assumes that the transport is HTTP and is therefore centered on HTTP status codes, which doesn't map well to @GZGavinZhao moss-fetcher + boulder git support PR.

Ikey suggested that we need to couple this with the error handling in moss.core, so capturing it here for reference and labelling it appropriately.

@ikeycode ikeycode transferred this issue from another repository Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants