Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Router 7 support? #220

Closed
4FunAndProfit opened this issue Nov 5, 2024 · 11 comments · Fixed by #223
Closed

React Router 7 support? #220

4FunAndProfit opened this issue Nov 5, 2024 · 11 comments · Fixed by #223

Comments

@4FunAndProfit
Copy link

Describe the bug

Hello,

For now, it seems like this package (which is an amzing work), is not adapted in his code and dpeendencies for RR7/remixv3 which will be available really soon (some pre packages are available),

Your Example Website or App

https://reactrouter.com/dev/docs/upgrading/remix

Steps to Reproduce the Bug or Issue

Are you planning to make this package work with RR7?

Thanks a lot in advance,

Expected behavior

Should be compatible with RR7

Screenshots or Videos

No response

Platform

N/A

Additional context

No response

@4FunAndProfit 4FunAndProfit changed the title React Server 7 support? React Router 7 support? Nov 5, 2024
@sergiodxa
Copy link
Owner

Once it's stable yes, but since that will require a new major release I don't plan to support it before that.

@4FunAndProfit
Copy link
Author

Thanks @sergiodxa :)
So I will Wait for stable version haha

@chinfeng
Copy link

client.ts#L11window.__remixRouteModules deprecated after rr7

@AlemTuzlak
Copy link
Contributor

Added a PR, a pre-release/or any other kind would be awesome!

@AlemTuzlak
Copy link
Contributor

Here is a temporary release until Sergio drops full support:

npm i https://pkg.pr.new/AlemTuzlak/remix-i18next@047de17

@4FunAndProfit
Copy link
Author

@AlemTuzlak You really are the best!!
I'll be able to test this on rr7 as well now.
Second time you've saved me with remix modules to rr7 haha 🥰

@AlemTuzlak
Copy link
Contributor

I am like your Remix fairy, I go around and add rr7 support to packages @4FunAndProfit 😂

@ThomasSchwengler
Copy link

React Router v7 just dropped

https://github.com/remix-run/react-router/releases/tag/react-router%407.0.0

@4FunAndProfit
Copy link
Author

@AlemTuzlak, My favorite little remix fairy 🧚🧚🧚 I don't know if you use nasa-gcn/remix-seo#20, it seems like you do (remix-run/remix#9682), if you want to do the remix/rr7 community another favor will be amazing 🥹❤️🧚

@AlemTuzlak
Copy link
Contributor

@4FunAndProfit I actually don't, I built my own package based on theirs and added extra features on top, check out forge42/seo-tools

@4FunAndProfit
Copy link
Author

@AlemTuzlak But it's even better haha ❤️🧚 thanks a lot 🧚🧚🧚🧚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants