Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monero-simple-request-rpc is inefficient #579

Open
kayabaNerve opened this issue Jul 15, 2024 · 0 comments
Open

monero-simple-request-rpc is inefficient #579

kayabaNerve opened this issue Jul 15, 2024 · 0 comments
Labels
feature New feature or request improvement This could be better monero An issue with the Monero library/integration

Comments

@kayabaNerve
Copy link
Member

kayabaNerve commented Jul 15, 2024

For each request, a dedicated connection is used. While there is internally a connection pool, connections should be reused at a higher level via JSON-RPC request/response IDs.

Low priority, yet would be important to anyone who wants a fast RPC. This isn't a breaking API change if monero-simple-request-transport manages the IDs. If we were to have monero-rpc do so, it would be (as the transport trait would need to be send request, yield responses).

@kayabaNerve kayabaNerve added feature New feature or request improvement This could be better monero An issue with the Monero library/integration labels Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request improvement This could be better monero An issue with the Monero library/integration
Projects
None yet
Development

No branches or pull requests

1 participant