Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build in progress status in build page #607

Conversation

munishchouhan
Copy link
Member

@munishchouhan munishchouhan commented Aug 20, 2024

This pr will add a binding in build view to show in progress status
Screenshot 2024-08-26 at 12 06 31

Signed-off-by: munishchouhan <[email protected]>
@munishchouhan munishchouhan self-assigned this Aug 20, 2024
@munishchouhan munishchouhan marked this pull request as draft August 20, 2024 15:33
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
@munishchouhan munishchouhan marked this pull request as ready for review August 20, 2024 15:47
Copy link
Collaborator

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I think we used grey in other pages? may the scan view? can you please align the style to it?

@munishchouhan
Copy link
Member Author

Nice. I think we used grey in other pages? may the scan view? can you please align the style to it?

@pditommaso are you referring to the background color?

@munishchouhan
Copy link
Member Author

munishchouhan commented Aug 23, 2024

Nice. I think we used grey in other pages? may the scan view? can you please align the style to it?

@pditommaso are you referring to the background color?

ok i got it, scan uses green, but adds a spinning icon, i will add that too

Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
@munishchouhan
Copy link
Member Author

munishchouhan commented Aug 23, 2024

style has been synced with scan
Screenshot 2024-08-23 at 13 21 41

@pditommaso
Copy link
Collaborator

great!

@ewels
Copy link
Member

ewels commented Aug 23, 2024

Can we align with Platform? That uses a blue for in-progress. Really I think that the design team should be involved here..

@pditommaso
Copy link
Collaborator

Desirable bot not a goal of this PR

@pditommaso pditommaso force-pushed the 511-build-page-reports-invalid-error-status-while-the-build-is-running branch from 5daaf85 to 389966f Compare August 28, 2024 07:12
@pditommaso
Copy link
Collaborator

How hard would be to make the page refresh while the status is "in progress" ? think it has been done somewhere else

@pditommaso
Copy link
Collaborator

Likely this

{{#if should_refresh}}
<meta http-equiv="refresh" content="5">
{{/if}}

@munishchouhan
Copy link
Member Author

How hard would be to make the page refresh while the status is "in progress" ? think it has been done somewhere else

I will add it

@munishchouhan
Copy link
Member Author

refresh has been added and tested successfully

Signed-off-by: munishchouhan <[email protected]>
@pditommaso pditommaso force-pushed the 511-build-page-reports-invalid-error-status-while-the-build-is-running branch from d8c23bd to dcb028c Compare August 29, 2024 06:43
@pditommaso pditommaso merged commit 3d940e8 into master Aug 29, 2024
4 checks passed
@pditommaso pditommaso deleted the 511-build-page-reports-invalid-error-status-while-the-build-is-running branch August 29, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build page reports invalid error status while the build is running
3 participants