-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add build in progress status in build page #607
add build in progress status in build page #607
Conversation
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I think we used grey in other pages? may the scan view? can you please align the style to it?
@pditommaso are you referring to the background color? |
…s-while-the-build-is-running
ok i got it, scan uses green, but adds a spinning icon, i will add that too |
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
great! |
Can we align with Platform? That uses a blue for in-progress. Really I think that the design team should be involved here.. |
Desirable bot not a goal of this PR |
src/main/groovy/io/seqera/wave/controller/ViewController.groovy
Outdated
Show resolved
Hide resolved
…s-while-the-build-is-running
5daaf85
to
389966f
Compare
How hard would be to make the page refresh while the status is "in progress" ? think it has been done somewhere else |
Likely this wave/src/main/resources/io/seqera/wave/scan-view.hbs Lines 4 to 6 in 389966f
|
I will add it |
refresh has been added and tested successfully |
Signed-off-by: munishchouhan <[email protected]>
d8c23bd
to
dcb028c
Compare
This pr will add a binding in build view to show in progress status