-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] Make CMake more flexible #3179
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #3179 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 269 269
Lines 11861 11861
=======================================
Hits 11641 11641
Misses 220 220 ☔ View full report in Codecov by Sentry. |
d574d0d
to
05754aa
Compare
find_package(Gtest) ignores the version specifier anyway https://salsa.debian.org/med-team/seqan3/-/blob/40f5a781a90f31c0fd7df199405e4f9bb3989a0a/debian/patches/better_gtest_benchmark_finding
https://salsa.debian.org/med-team/seqan3/-/tree/40f5a781a90f31c0fd7df199405e4f9bb3989a0a/debian/patches
Commit 1 makes
find_package
accept any Google Test and Google Benchmark version.find_package(GTest)
ignores the version specifier anyway.Relevant patch
Commit 2 adds an option to pass a path to a tag file, which is then copied.
Relevant patch
CMake solution:
Other patches:
-DSEQAN3_CLONE_DIR=...
to CMake.