Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Make CMake more flexible #3179

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Jul 24, 2023

https://salsa.debian.org/med-team/seqan3/-/tree/40f5a781a90f31c0fd7df199405e4f9bb3989a0a/debian/patches

Commit 1 makes find_package accept any Google Test and Google Benchmark version.
find_package(GTest) ignores the version specifier anyway.
Relevant patch

Commit 2 adds an option to pass a path to a tag file, which is then copied.
Relevant patch
CMake solution:

cmake [...] -DSEQAN3_DOXYGEN_STD_TAGFILE=/usr/share/devhelp/books/cppreference-doxygen-web.tag.xml

Other patches:

  • Doxygen config patch: This is due to mismatching doxygen versions. We kinda only support the version we currently use, because doxygen often has breaking changes.
  • Post-install test license dir: IMO this should be resolvable via passing -DSEQAN3_CLONE_DIR=... to CMake.

@vercel
Copy link

vercel bot commented Jul 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
seqan3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 10:47am

@seqan-actions seqan-actions added the lint [INTERNAL] signal for linting label Jul 24, 2023
@eseiler eseiler requested a review from mr-c July 24, 2023 15:43
@seqan-actions seqan-actions removed the lint [INTERNAL] signal for linting label Jul 24, 2023
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (165a495) 98.14% compared to head (aac2e07) 98.14%.

❗ Current head aac2e07 differs from pull request most recent head 3e20d23. Consider uploading reports for the commit 3e20d23 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3179   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         269      269           
  Lines       11861    11861           
=======================================
  Hits        11641    11641           
  Misses        220      220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Aug 9, 2023
@eseiler eseiler force-pushed the infra/patches branch 2 times, most recently from d574d0d to 05754aa Compare August 9, 2023 09:32
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Aug 9, 2023
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Aug 9, 2023
@eseiler eseiler removed the request for review from mr-c August 9, 2023 10:41
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Aug 9, 2023
@seqan-actions seqan-actions added the lint [INTERNAL] signal for linting label Aug 9, 2023
@seqan-actions seqan-actions removed the lint [INTERNAL] signal for linting label Aug 9, 2023
@eseiler eseiler merged commit 140112e into seqan:master Aug 9, 2023
44 of 45 checks passed
@eseiler eseiler deleted the infra/patches branch August 9, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants