[TEST] Add compute_ibf_size test. #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smehringer
commented
Oct 26, 2023
smehringer
commented
Oct 26, 2023
smehringer
commented
Oct 26, 2023
Co-authored-by: Enrico Seiler <[email protected]>
eseiler
force-pushed
the
compute_ibf_size_test
branch
from
5b49f55
to
c9bfdc7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
=======================================
Coverage 95.93% 95.93%
=======================================
Files 19 19
Lines 688 688
=======================================
Hits 660 660
Misses 28 28 ☔ View full report in Codecov by Sentry. |
eseiler
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that display_layout in chopper does not compute wrong sizes but is in sync with the hibf lib function
construct_ibfTodo:
compute_ibf_size.hppin test