Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix qless:work rake task #198

Closed
wants to merge 1 commit into from
Closed

Conversation

databus23
Copy link
Contributor

This is a pull request for #168 and #197.
Setting up a qless worker in the current master is pretty impossible without significant knowledge of the qless code or by finding this comment from @myronmarston.
Until the planned standalone binary exists I suggest to fix the rake task so that it matches again the documentation in the README.

@myronmarston
Copy link
Contributor

We decided to do away with the rake task instead. The rake task approach works well for resque because there is very little config to run a worker, so you can just pass an ENV var or two. For Qless, the worker is super flexible and configurable (supporting redis sharding, different job reservation strategies, middleware modules and more) and you're really better off writing your own task to instantiate and run the worker configured according to your needs. So in #213 I did away with the task entirely.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants