Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fail safely if data import is not successful #307

Open
rpruim opened this issue Dec 2, 2022 · 1 comment
Open

Bug: Fail safely if data import is not successful #307

rpruim opened this issue Dec 2, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@rpruim
Copy link
Collaborator

rpruim commented Dec 2, 2022

We saw an example at the workshop where an an error during data loading led to a javascript error that caused the app not to display anything. Since things are cached, refreshing the page just led to the same issue. We were able to resolve this by clearing the data from the browser, but it would be better to catch errors and have the app react to them.

@rpruim rpruim added the bug Something isn't working label Dec 2, 2022
@charkour
Copy link
Collaborator

charkour commented Dec 2, 2022

Yeah, we should add Error Boundaries to the app in different levels of the component tree. We should use this package because it allows the app to display a fallback where we can provide a reset button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants