Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Tally refactor to updated specs #451

Open
2 of 4 tasks
hacheigriega opened this issue Dec 20, 2024 · 1 comment · May be fixed by #452
Open
2 of 4 tasks

♻️ Tally refactor to updated specs #451

hacheigriega opened this issue Dec 20, 2024 · 1 comment · May be fixed by #452
Labels
type: refactor ♻️ Code change that neither fixes a bug nor adds a feature

Comments

@hacheigriega
Copy link
Member

hacheigriega commented Dec 20, 2024

♻️ Refactor

Before implementing incentive features for tally, refactor the tally process to the updated specs described here.

Specific tasks would involve:

  • Reordering the tally process to follow: filtering -> tally execution -> payout calculation
  • Requestor-provided filter should be fully validated before the specific filter is applied. In other words, any errors due to requestor's fault in constructing the filter input should be handled before the specific filter is applied.
  • Update the tally process logic. Consensus is now determined by tracking lists of successful reports and error reports, where a successful report is a zero-exit code reveal in "agreement" and an error report is any non-zero exit code reveal or a reveal that is not in "agreement."
  • Update the relevant tests accordingly. Add more tests if necessary.
@hacheigriega hacheigriega added the type: refactor ♻️ Code change that neither fixes a bug nor adds a feature label Dec 20, 2024
@hacheigriega hacheigriega linked a pull request Dec 20, 2024 that will close this issue
@Thomasvdam
Copy link
Member

It probably makes sense to consider timed-out DRs separately (the case where there are not enough commitments). After a short discussion Mario and I created #453 to keep track of this flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor ♻️ Code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants