make all functions generic over f32 and f64 #19
Labels
enhancement
New feature or request
librosa_compat
related to ensuring compatibility with librosa's mel spectrogram and mfcc implementation
Probably should hold off on this until we have some benchmarking code within rust. There are use cases where f32 would be preferred. If possible, we should make the functions generic over f32 and f64, preferably in a way that wouldn't require specifying types user-side. We can use
num_traits
for specifying the type. So far the type definition I have that works in the bit of code I tested it with isthe
from<f32>
is so that we can autoconvert primitives used in computation like2.0_f32 as F
which IMO isn't as ugly asF::from(2.0).unwrap()
potentially useful links:
The text was updated successfully, but these errors were encountered: