Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to phpseclib version 3 #352

Open
getpinga opened this issue Nov 27, 2023 · 2 comments
Open

Upgrade to phpseclib version 3 #352

getpinga opened this issue Nov 27, 2023 · 2 comments

Comments

@getpinga
Copy link

Is there a reason why phpseclib/phpseclib 3.0 is not supported?

Can I help somehow to add support for it?

Thanks

@sebastianfeldmann
Copy link
Owner

sebastianfeldmann commented Nov 27, 2023

No particular reason. If we don't have to make weird version if else stuff I don't see any reason to not support it.

@sebastianfeldmann
Copy link
Owner

phpseclib changed a lot of the API phpbu uses to do SFTP stuff.

Currently there is no way to support both out of the box because the changes are to big to handle in a couple of if else.

Either, we have to build a SFTPClient interface and write the SFTPClientPHPSecLibV2 and SFTPClientPHPSecLibV3 implementations. Then change all phpbu stuff to use the SFTPClient interface and finally write a SFTPClientFactory that creates a client depending on what dependency is loaded.

OR and that would be my preferred way kill support for everything below phpseclib v3 and update everything so it works with the latest version.

@sebastianfeldmann sebastianfeldmann changed the title Exception with phpseclib/phpseclib 3.0 Upgrade to phpseclib version 3 Dec 22, 2023
Repository owner deleted a comment from YouveGotMeowxy Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants