Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing quotas for dynamodb #3

Open
1 of 7 tasks
sebasrp opened this issue Sep 14, 2022 · 2 comments
Open
1 of 7 tasks

Add missing quotas for dynamodb #3

sebasrp opened this issue Sep 14, 2022 · 2 comments

Comments

@sebasrp
Copy link
Owner

sebasrp commented Sep 14, 2022

DynamoDb quota coverage is not completed - see table below for quotas that exist that are supported in service quotas

  • Account-level read throughput limit (Provisioned mode)
  • Account-level write throughput limit (Provisioned mode)
  • Global Secondary Indexes per table
  • Maximum number of tables
  • Table-level read throughput limit
  • Table-level write throughput limit
  • Write throughput limit for DynamoDB Streams (Provisioned mode)

For detailed on these quotas, check the official documentation

Changes will be on https://github.com/sebasrp/awslimitchecker/blob/main/internal/services/dynamodb.go

@sebasrp sebasrp changed the title Add Support for dynamodb Add missing quotas for dynamodb Sep 16, 2022
@CodeWAdi
Copy link

CodeWAdi commented Oct 2, 2022

can you explain in bit detail what do I have to do

@sebasrp
Copy link
Owner Author

sebasrp commented Oct 2, 2022

All changes should only be needed to be done in https://github.com/sebasrp/awslimitchecker/blob/main/internal/services/dynamodb.go and the respective https://github.com/sebasrp/awslimitchecker/blob/main/internal/services/dynamodb_test.go file.

Pick one quota you want to implement, then:

  1. Add it to https://github.com/sebasrp/awslimitchecker/blob/main/internal/services/dynamodb.go#L16
  2. Implement the function that you will use to measure usage
  3. Add respective test

For eg, for quota Account-level read throughput limit (Provisioned mode) you would need to iterate through the list of tables and sum the provisioned iops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants