Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Implement OIDC authorization flow #350

Open
winston0410 opened this issue Oct 24, 2024 · 4 comments
Open

[REQUEST] Implement OIDC authorization flow #350

winston0410 opened this issue Oct 24, 2024 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@winston0410
Copy link

Is your feature request related to a problem? Please describe.
I would like to authorize user with external IDP and giving them access to AdventureLog without registering again.

Describe the solution you'd like
Adventurelog to support basic OIDC authorization flow. It doesn't have to be PKCE, the basic flow with client id and client secret should solve the problem

Describe alternatives you've considered
SAML and LDAP. These two approaches are more complex, and OIDC is more modern

Additional context
Add any other context or screenshots about the feature request here.

@winston0410 winston0410 added the enhancement New feature or request label Oct 24, 2024
@Aesgarth
Copy link

I'd love to see this too

@seanmorley15
Copy link
Owner

I am looking into this right now! I want to actually revamp the auth system first, this would mean moving from the current auth system (dj-rest-auth) which is limited to basically just signup and registration, to allauth which has a lot more features like MFA and ODIC (also will make it easier to support a future AdventureLog mobile app 🤫)

@seanmorley15 seanmorley15 added this to the AdventureLog v0.8.0 milestone Nov 11, 2024
@nebriv
Copy link

nebriv commented Dec 9, 2024

Using allauth is a great solution, I use it in many of my django projects. +1! Its a well thought out library, hopefully the migration isn't too painful!

@seanmorley15
Copy link
Owner

seanmorley15 commented Dec 9, 2024

I am currently working on the AllAuth system in the development branch. I am just working some things out before its released but it should not require any manual migration. Thankfully Django makes the whole auth switch really easy!
This will migrate from JWT to session based auth and add MFA as well!

@seanmorley15 seanmorley15 added the help wanted Extra attention is needed label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants