Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set OpenSBI dependencies right #121

Open
axel-h opened this issue Sep 27, 2021 · 0 comments
Open

set OpenSBI dependencies right #121

axel-h opened this issue Sep 27, 2021 · 0 comments

Comments

@axel-h
Copy link
Member

axel-h commented Sep 27, 2021

Follow-up from #117 concerning file(GLOB_RECURSE deps)

From @kent-mcleod: It looks like it's missing the other parts of it's implementation, actually specifying the path to the opensbi sources and then adding the sources to the depends line of add_custom_command. If you wanted to add a commit to this PR adding ${BBL_PATH} to the end of that statement, and also adding the deps arg to the ${CMAKE_BINARY_DIR}/bbl/bbl custom command [...]. Alternatively you could ignore it, or remove it if you think it's better to assume that the opensbi implementation isn't going to be edited by anyone between builds.

@axel-h axel-h changed the title set OpenSBi dependencies right set OpenSBI dependencies right Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant