You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
style-cmake.sh resets the file mode, using cmake-format with -i which always produces 644 files.
It'd be nice to keep the original file mode, since we have some cmake files that are intentionally 755.
This could be achieved in style-cmake.sh by processing files one by one, using stat to read the mode, then chmod to set it afterwards, or some such thing. Downside is that this probably will make it quite hard to deal with file names that have spaces in them.
Alternatively, we could do something similar in python inside style.py.
The text was updated successfully, but these errors were encountered:
style-cmake.sh
resets the file mode, usingcmake-format
with-i
which always produces644
files.It'd be nice to keep the original file mode, since we have some cmake files that are intentionally
755
.This could be achieved in
style-cmake.sh
by processing files one by one, usingstat
to read the mode, thenchmod
to set it afterwards, or some such thing. Downside is that this probably will make it quite hard to deal with file names that have spaces in them.Alternatively, we could do something similar in python inside
style.py
.The text was updated successfully, but these errors were encountered: