Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single alpine/sockat container for port mapping for each environment #24

Open
se7entyse7en opened this issue Mar 23, 2019 · 2 comments
Labels
confirmed This is something confirmed to be done enhancement New feature or request help wanted Extra attention is needed need investigation This issue need investigation

Comments

@se7entyse7en
Copy link
Owner

se7entyse7en commented Mar 23, 2019

Currently, the container corresponding to an environment is started without mapping any port. Mapping a port would require a restart of the container. To avoid the restart, port mapping is achieved by forwarding the tcp traffic using an alpine/socat container. But currently a container for each port is spun up, this could be improved by using a single alpine/socat container to handle all the ports forwarding.

@stale
Copy link

stale bot commented Jun 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale This doesn't receive recent activity label Jun 28, 2019
@stale stale bot closed this as completed Jul 19, 2019
@se7entyse7en se7entyse7en reopened this Aug 12, 2019
@stale stale bot removed the stale This doesn't receive recent activity label Aug 12, 2019
@se7entyse7en se7entyse7en added confirmed This is something confirmed to be done enhancement New feature or request labels Aug 12, 2019
@se7entyse7en
Copy link
Owner Author

This is not trivial.

If multiple ports must be opened in the same command, then it's easy to achieve. We just need to run multiple socat instances inside the same container. The problem is that if multiple ports are requested on different commands. The second command would need that the port mapper already has the newly requested port open.

An idea could be to restart the port mapper container which most probably is less expensive than restarting the environment container, but all the traffic flowing in currently open ports will break and this is unexpected to the user.

@se7entyse7en se7entyse7en added help wanted Extra attention is needed need investigation This issue need investigation labels Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed This is something confirmed to be done enhancement New feature or request help wanted Extra attention is needed need investigation This issue need investigation
Projects
None yet
Development

No branches or pull requests

1 participant