Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support num_samples < batch_size #41

Open
csala opened this issue Sep 19, 2019 · 0 comments
Open

Support num_samples < batch_size #41

csala opened this issue Sep 19, 2019 · 0 comments
Labels
approved The issue is approved and someone can start working on it enhancement New feature or request

Comments

@csala
Copy link
Contributor

csala commented Sep 19, 2019

The current implementation ends up in an infinite loop if the num_samples is lower than the batch_size.

This should be prevented by either always sampling at least one batch, or making the batch_size equal to the num_samples if the later is lower.

@csala csala added approved The issue is approved and someone can start working on it enhancement New feature or request labels Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The issue is approved and someone can start working on it enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant