Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threadpool assigns work to the main thread if only 1 task is submitted #255

Open
twaritwaikar opened this issue Sep 8, 2020 · 0 comments
Labels
bug Something isn't working needs-testing Needs to be tested for confirmation

Comments

@twaritwaikar
Copy link
Member

    ThreadPool& preloadThreads = Application::GetSingleton()->getThreadPool();
	Vector<Ref<Task>> preloadTasks;

	progress = 1;
	for (auto& path : empericalPaths)
	{
		Ref<Task> loadingTask(new Task([=, &progress]() {
			CreateSomeResourceFile(path);
			progress++;
		}));
		preloadTasks.push_back(loadingTask);
	}

	preloadTasks.push_back(Ref<Task>(new Task([]() {})));

	preloadThreads.submit(preloadTasks);

We currently have to add a dummy task to get around this

@twaritwaikar twaritwaikar added the bug Something isn't working label Sep 8, 2020
@twaritwaikar twaritwaikar added the needs-testing Needs to be tested for confirmation label Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-testing Needs to be tested for confirmation
Projects
None yet
Development

No branches or pull requests

1 participant