Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider auto-versioning #81

Open
mikenye opened this issue Aug 1, 2022 · 1 comment
Open

Consider auto-versioning #81

mikenye opened this issue Aug 1, 2022 · 1 comment
Assignees

Comments

@mikenye
Copy link
Member

mikenye commented Aug 1, 2022

Hi @fredclausen,

I'm wondering if we should look at auto-versioning using something like this: https://crates.io/crates/cargo-bump

This way, we get a new patch release on commit. We can likely manage the major/minor versioning manually - possibly by adding a variable to workflow-dispatch...

Let me know what you think.

@fredclausen
Copy link
Member

I really like this. Some immediate thoughts:

  • It would be really annoying to have it bump the minor version 4-5 times if we had a lot of cargo packages updated with dependabot PRs. I've used a workflow on ACARS Hub (https://github.com/sdr-enthusiasts/docker-acarshub/blob/main/.github/workflows/combine_prs.yml) that will combine PRs from dependabot. It doesn't really work all that well in ACARS Hub because dependabot PRs tend to fail on the on_pr build because of an auth/push issue I've never bothered to figure out so the workflow is never run, but that is a specific problem with that repo. We shouldn't have that issue here, and having one PR and one version bump seems ideal.
  • For PRs we generate that would require a patch / major bump that seems less obvious how it would "just work" (but could also be my caffeination state at the moment....), but I assume it's an issue we would be able to work around.

In an ideal world I would love the CI to generate a PRs from dependabot, build, verify they pass the cargo test and any other tests we have, merge in with a minor version bump, and then build a new release, completely automatically.

Right now while we verify functionality and iterate the code base to be robust we should not do auto merges, but that's where I feel we should end up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants