Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of SerializedValues from public API #1152

Open
Lorak-mmk opened this issue Dec 16, 2024 · 1 comment
Open

Remove uses of SerializedValues from public API #1152

Lorak-mmk opened this issue Dec 16, 2024 · 1 comment
Assignees
Labels
API-breaking This might introduce incompatible API changes API-stability Part of the effort to stabilize the API area/metadata
Milestone

Comments

@Lorak-mmk
Copy link
Collaborator

Those uses are a leftover from previous API and should be removed - most likely replaced with impl SerializeRow

Usages to be removed:
https://docs.rs/scylla/latest/scylla/transport/partitioner/fn.calculate_token_for_partition_key.html
https://docs.rs/scylla/latest/scylla/transport/struct.ClusterData.html#method.compute_token
https://docs.rs/scylla/latest/scylla/transport/struct.ClusterData.html#method.get_endpoints

@Lorak-mmk Lorak-mmk self-assigned this Dec 16, 2024
@Lorak-mmk Lorak-mmk added API-breaking This might introduce incompatible API changes API-stability Part of the effort to stabilize the API area/metadata labels Dec 16, 2024
@Lorak-mmk Lorak-mmk added this to the 0.16.0 milestone Dec 16, 2024
@Lorak-mmk
Copy link
Collaborator Author

I think it has dependency on #691
The reason is that we need to create RowSerializationContext, which operates on ColumnSpec (which contains ColumnType), using Table, containing pub columns: HashMap<String, Column>, - and Column contains CqlType.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API-breaking This might introduce incompatible API changes API-stability Part of the effort to stabilize the API area/metadata
Projects
None yet
Development

No branches or pull requests

1 participant