Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScyllaClusters connected into a multi-datacenter cluster with externalSeeds are registered as separate clusters with Scylla Manager #2119

Open
Tracked by #1939
rzetelskik opened this issue Sep 10, 2024 · 2 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@rzetelskik
Copy link
Member

@Michal-Leszczynski discovered that when we useexternalSeeds to connect two ScyllaClusters (datacenters) into a single, multi-dc cluster, both ScyllaClusters are being registered with Scylla Manager as separate clusters with distinct IDs by the manager controller. It can be observed e.g. in the e2e test for external seeds: https://github.com/scylladb/scylla-operator/blob/master/test/e2e/set/scyllacluster/scyllacluster_external_seeds.go.

It's an issue since it can possibly break some of the operations performed by manager, e.g. the two registered clusters wouldn't be protected from running a backup simultaneously.

We should only register all ScyllaClusters, being part of the same logical cluster, with manager once, and the same ID should be propagated to their statuses.

Since the DCs share a common cluster name, this can most likely be fixed as part of #1902, but we should consider adding a dedicated e2e test verifying that the clusters are indeed only registered once.

/priority important-longterm
/kind bug
/assign

@scylla-operator-bot scylla-operator-bot bot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/bug Categorizes issue or PR as related to a bug. labels Sep 10, 2024
Copy link
Contributor

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out

/lifecycle stale

@scylla-operator-bot scylla-operator-bot bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 11, 2024
@tnozicka
Copy link
Member

/remove-lifecycle stale
/triage accepted

@scylla-operator-bot scylla-operator-bot bot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants