Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep only typing from arguments #74

Closed
quentinblampey opened this issue May 21, 2024 · 4 comments
Closed

Keep only typing from arguments #74

quentinblampey opened this issue May 21, 2024 · 4 comments

Comments

@quentinblampey
Copy link
Contributor

As mentioned by @Zethson in #70, there are typehints inside the docstrings, while the function arguments are already typed.

To make it easier to maintain, I think we should only keep the typing from the function arguments, and make sure the docs are still showing them. Is there a particular reason to keep them both @mbuttner?

@grst
Copy link
Collaborator

grst commented May 21, 2024

#66 will ensure that the docs do show them.

@mbuttner
Copy link
Collaborator

mbuttner commented May 21, 2024

Thanks for pointing this out. The only reason was that sometimes the typing didn't work smoothly, but other than that, there was no particular reason to duplicate. So let's remove them.

@grst
Copy link
Collaborator

grst commented Jun 4, 2024

@quentinblampey, did you actually fix that everywhere in #66 or shall we keep this issue open?

@quentinblampey
Copy link
Contributor Author

Yes, it should be all fixed now
I'm closing this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants