-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove _models.py
#248
Comments
|
This is resolved now, correct? @melonora |
I think @melonora did some magic and indeed it automagically disappeared. But I am not sure this was pushed/merged. |
Jup during the ghent hackathon |
As discussed during the VIB Ghent 2024 hackathon with @giovp and @melonora, removing the legacy
_models.py
from the codebase, and access the data directly formlayer.metadata['sdata']
would improve the robustness of the code.In particular we should rely on
get_values()
for fetching annotations instead of the currently usedget_obs()
,get_var()
etc.A positive implication of this refactoring is that the mismatch between the annotation indices shown by napari, and the indices used by
SpatialData
, would disappear, therefore fixing this bug: #242.The text was updated successfully, but these errors were encountered: