Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _models.py #248

Open
LucaMarconato opened this issue Jun 10, 2024 · 4 comments
Open

Remove _models.py #248

LucaMarconato opened this issue Jun 10, 2024 · 4 comments

Comments

@LucaMarconato
Copy link
Member

As discussed during the VIB Ghent 2024 hackathon with @giovp and @melonora, removing the legacy _models.py from the codebase, and access the data directly form layer.metadata['sdata'] would improve the robustness of the code.

In particular we should rely on get_values() for fetching annotations instead of the currently used get_obs(), get_var() etc.

A positive implication of this refactoring is that the mismatch between the annotation indices shown by napari, and the indices used by SpatialData, would disappear, therefore fixing this bug: #242.

@melonora
Copy link
Collaborator

get_values won't entirely work. It requires a refactor because currently if you pass on an element it is not allowed to be a table.

@LucaMarconato
Copy link
Member Author

LucaMarconato commented Jul 10, 2024

get_values won't entirely work. It requires a refactor because currently if you pass on an element it is not allowed to be a table.

This is resolved now, correct? @melonora

@giovp
Copy link
Member

giovp commented Jul 10, 2024

I think @melonora did some magic and indeed it automagically disappeared. But I am not sure this was pushed/merged.

@melonora
Copy link
Collaborator

Jup during the ghent hackathon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants