-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump min Python to 3.9 #1117
Bump min Python to 3.9 #1117
Conversation
f1017ca
to
9ec0ac1
Compare
bf91860
to
b746b97
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1117 +/- ##
==========================================
- Coverage 84.97% 81.67% -3.30%
==========================================
Files 36 36
Lines 5197 5305 +108
==========================================
- Hits 4416 4333 -83
- Misses 781 972 +191
Flags with carried forward coverage won't be shown. Click here to find out more.
|
176005c
to
b2ea6d6
Compare
282125a
to
9dbb96d
Compare
129db88
to
dd4f7dc
Compare
dd4f7dc
to
d801da6
Compare
I've merged a version of this PR closer to the set of changes from when I reviewed last week. I did include a few more of the rules you added here. Could you open an issue for follow up? From time spent investigating these changes:
|
Currently, this adds all checks I think are very useful, minus the following that require more substantive changes:
B028
/no-explicit-stacklevel: we should do this for more useful warning stack locationsFBT
/flake8-boolean-trap: very useful for a future API updatePT
/flake8-pytest-style very useful, but needs a lot of changesPD
/pandas-vetThe following stylistic rulesets are useful enough to go for but also need quite some changes
D
/pydocstyleRET
/[return style] Clarifies early returns (if thing: return\nelse: ...
→if thing: return\...
)Instead of
FA
we just addfrom __future__ import annotations
automatically everywhere.The idea is that before the 0.10 release, we
git reset --hard <first commit in this PR>
and thengit rebase main
this branchanndata/anndata/_core/index.py
Lines 41 to 47 in b746b97
cabc.???
tofrom collections.abc import ???
profitmerge