-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict files written by tests #1061
Conversation
flying-sheep
commented
Jul 17, 2023
•
edited
Loading
edited
- Closes Stop tests from writing files everywhere #1060
- Tests added
- Release note unnecessary
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
==========================================
- Coverage 84.90% 84.75% -0.15%
==========================================
Files 36 36
Lines 5133 5149 +16
==========================================
+ Hits 4358 4364 +6
- Misses 775 785 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@ivirshup implemented your suggestions from the call! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give a summary of what goes where? Is it only coverage that's going into test-data
?
Also, I get why you want to make the data files not be written to the root. Why move test outputs like reports and coverage from their default locations? |
documented in .gitignore: Lines 17 to 18 in 4c016d2
so test outputs end up in one location that can be .gitignored instead of polluting the project directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to change local behavior, so have made a set of suggestions reverting that. Otherwise looks good.
documented in .gitignore:
I'm not completley clear on what counts as a "test-result".
Co-authored-by: Isaac Virshup <[email protected]>
plural. a file recording the test results. in the “nunit” or “junit” format
then I’ll merge. |
Co-authored-by: Isaac Virshup <[email protected]>