Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu items for social links #315

Closed
2 tasks done
andrewtavis opened this issue May 21, 2023 · 5 comments
Closed
2 tasks done

Menu items for social links #315

andrewtavis opened this issue May 21, 2023 · 5 comments
Assignees
Labels
feature New feature or request GSoC Available for Google Summer of Code participants help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented May 21, 2023

Terms

Description

This issue is to create menu items for the various social links that the Scribe community has within the about tab of the menu being created in #16. These links are detailed in the designs in Figma :) The links we need are:

Note:

Contribution

This issue is a part of Google Summer of Code 2023 ☀️ Happy to support as needed 😊

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed blocked Another issue is blocking GSoC Available for Google Summer of Code participants labels May 21, 2023
@SaurabhJamadagni
Copy link
Collaborator

Hey @andrewtavis, we are checking if the base iOS version is above or below 10 in the code below. Do we need this check as Scribe seems to have a deployment target of iOS 13.0? I couldn't think of any use case and just wanted to make sure.

if #available(iOS 10.0, *) {
UIApplication.shared.open(url, options: [:], completionHandler: nil)
} else {
UIApplication.shared.openURL(url)
}
}

@andrewtavis
Copy link
Member Author

Thanks for pointing this out, @SaurabhJamadagni! I don’t think we need this, no. If memory serves me there’s something having to do with icons that means we need the v13.0+, and this code was likely put in before that was required. At least I hope 😅😅

@andrewtavis andrewtavis removed the blocked Another issue is blocking label Jun 8, 2023
@andrewtavis andrewtavis moved this from Todo to Done in Scribe Board Jun 8, 2023
@andrewtavis andrewtavis moved this from Done to In Progress in Scribe Board Jun 8, 2023
@SaurabhJamadagni
Copy link
Collaborator

Also @andrewtavis, could you reshare the temporary email address we are redirecting the user to? I can't remember what it was 😅

@andrewtavis
Copy link
Member Author

[email protected]

I have some notes on potential URLs for next week :)

@andrewtavis
Copy link
Member Author

Closed via #328 😊 Thank you, @SaurabhJamadagni! 🥳

@github-project-automation github-project-automation bot moved this from In Progress to Done in Scribe Board Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request GSoC Available for Google Summer of Code participants help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants