-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu items for social links #315
Comments
Hey @andrewtavis, we are checking if the base iOS version is above or below 10 in the code below. Do we need this check as Scribe seems to have a deployment target of iOS 13.0? I couldn't think of any use case and just wanted to make sure. Scribe-iOS/Scribe/ViewController.swift Lines 347 to 352 in fa59078
|
Thanks for pointing this out, @SaurabhJamadagni! I don’t think we need this, no. If memory serves me there’s something having to do with icons that means we need the v13.0+, and this code was likely put in before that was required. At least I hope 😅😅 |
Also @andrewtavis, could you reshare the temporary email address we are redirecting the user to? I can't remember what it was 😅 |
I have some notes on potential URLs for next week :) |
Closed via #328 😊 Thank you, @SaurabhJamadagni! 🥳 |
Terms
Description
This issue is to create menu items for the various social links that the Scribe community has within the about tab of the menu being created in #16. These links are detailed in the designs in Figma :) The links we need are:
Note:
Contribution
This issue is a part of Google Summer of Code 2023 ☀️ Happy to support as needed 😊
The text was updated successfully, but these errors were encountered: