Refactor colors across Scribe-iOS

[andrewtavis]

Terms

• I have searched open and closed feature requests
• I agree to follow Scribe-iOS' Code of Conduct

Description

As discussed in #166, the way that Scribe assigns colors is highly verbose and error prone. It would be better if the colors were defined in an asset file and accessed via an enum. This would allow us to not need to check for the traitCollection each time the color might switch based on light or dark mode.

Contribution

This issue has already been requested as part of Hacktoberfest, and I'll of course be happy to support where needed 😊

[misteu]

Hey!
Thanks for creating the issue :) As discussed, I'm happy to help you out with this one.

[andrewtavis]

Assigned! Thanks for your willingness to help out! :) I'd say this might want to wait for #210, which should be closed by tomorrow 😊

[andrewtavis]

@misteu, wanted to let you know that the major changes that were being worked on for v2.0.0 are now all done, so the repo isn't nearly as in flux as it was 😇 Let me know if you need any help or information for this issue!

Sent the new version to Apple just a bit ago, so hopefully it'll be out in 48 hours 🚀😊

[andrewtavis]

There's also a 1x1 conjugation/declension view that could be used for the information icon button that you implemented in #166. The issue to add a message to the user when they click that is #214 :)

[misteu]

I created a PR for it, see #228

It looks like a lot of changes but most of it are added color asset JSONs as you will see :)

[andrewtavis]

Thank you, @misteu! I'll take a look at all of this tomorrow :) Really looking forward to these changes and learning more about the methods you're using 😊

[andrewtavis]

Thanks for all your work here, @misteu! Let me know if you have interest in anything else :) Big thing we're focussing on is #96 at the moment, and with that reworking the we read in data. At this point the Russian keyboard is crashing from the outset, with the current theory being that the JSONs being loaded in are much too large. I'll be looking into Core Data as suggested by another contributor 😊 You're of course welcome to work on anything that interests you, and know that your input is highly valued! Really has been great to have you 🚀

Thanks again so much 🙏