From 1debb3695d9c8d3df9cc6e24b8538a54f5fe3dea Mon Sep 17 00:00:00 2001 From: Dao Lam Date: Wed, 2 May 2018 11:55:06 -0700 Subject: [PATCH] fix: add start/stop periodic functions --- index.js | 18 ++++++++++++++++++ package.json | 2 +- test/index.test.js | 8 ++++++++ 3 files changed, 27 insertions(+), 1 deletion(-) diff --git a/index.js b/index.js index 3495030..d1173c8 100644 --- a/index.js +++ b/index.js @@ -301,6 +301,24 @@ class JenkinsExecutor extends Executor { params: [{ name: jobName }] }); } + + /** + * Starts a new periodic build in an executor + * @method _startPeriodic + * @return {Promise} Resolves to null since it's not supported + */ + async _startPeriodic() { + return Promise.resolve(null); + } + + /** + * Stops a new periodic build in an executor + * @method _stopPeriodic + * @return {Promise} Resolves to null since it's not supported + */ + async _stopPeriodic() { + return Promise.resolve(null); + } } module.exports = JenkinsExecutor; diff --git a/package.json b/package.json index da5a160..575d9c2 100644 --- a/package.json +++ b/package.json @@ -44,7 +44,7 @@ "circuit-fuses": "^2.2.1", "jenkins": "^0.20.0", "request": "^2.72.0", - "screwdriver-executor-base": "^5.2.0", + "screwdriver-executor-base": "^6.1.0", "tinytim": "^0.1.1", "xml-escape": "^1.1.0" }, diff --git a/test/index.test.js b/test/index.test.js index 6140284..bfcdf7e 100644 --- a/test/index.test.js +++ b/test/index.test.js @@ -394,6 +394,14 @@ describe('index', () => { }); }); + describe('periodic', () => { + it('resolves to null when calling periodic start', + () => executor.startPeriodic().then(res => assert.isNull(res))); + + it('resolves to null when calling periodic stop', + () => executor.stopPeriodic().then(res => assert.isNull(res))); + }); + describe('_loadJobXml', () => { let fsMock;