Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing block comments are included in the undo stack when loading a project, lose their content on redo #3014

Closed
towerofnix opened this issue Apr 9, 2023 · 2 comments

Comments

@towerofnix
Copy link
Contributor

Expected Behavior

The undo/redo stack for a given workspace only ever contains specific actions the user takes. Also, "redo" always fully restores the changes undone by "undo".

Actual Behavior

Loading a project with block comments considers loading each of those comments an "action" for undo/redo purposes. Pressing undo removes the comment. Then, pressing redo doesn't restore the contents of the comment, leading to data loss.

Steps to Reproduce

  1. Create a new, blank project
  2. Drag out any block
  3. Right click the block and choose "add comment"
  4. Type something in the comment
  5. Save and reload the project (F5)
  6. Press ctrl/cmd+Z or right click -> undo
    • Note the comment disappears
  7. Press shift+ctrl/cmd+Z or right click -> redo
    • Note the comment reappears attached to the block but has no contents

Operating System and Browser

N/A (macOS 13.4, Chromium 112; first reported by a Scratcher on unknown browser/device)

@towerofnix
Copy link
Contributor Author

towerofnix commented Apr 9, 2023

See also:

@towerofnix
Copy link
Contributor Author

Whoops, duplicate of #1973!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant