Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparency for telescope #147

Open
shouyierban opened this issue Nov 4, 2024 · 14 comments · May be fixed by #150
Open

Transparency for telescope #147

shouyierban opened this issue Nov 4, 2024 · 14 comments · May be fixed by #150
Labels
bug Something isn't working

Comments

@shouyierban
Copy link

shouyierban commented Nov 4, 2024

Description

hi scottmckendry, thank you for your job, and this is a very nice theme.
this is a problem about Transparency. when I set cache = true, the transparency of telescope and neotree become to invalid, even if I delete the old cache files。Hopefully you can fix it.

image

Neovim version?

v0.10

@shouyierban shouyierban added the bug Something isn't working label Nov 4, 2024
@scottmckendry
Copy link
Owner

hello @shouyierban :)
Can you share your config, I'm not able to replicate the above with my testing.

You may need to run :CyberdreamBuildCache with cache disabled to get the desired result.

@scottmckendry scottmckendry added the waiting for op This issue is waiting for a response from the original poster label Nov 4, 2024
@shouyierban
Copy link
Author

shouyierban commented Nov 4, 2024

thank you for your reply, here is my config:

return {
    "scottmckendry/cyberdream.nvim",
    -- dev = true,
    lazy = false,
    priority = 1000,
    config = function()
      require("cyberdream").setup({
          transparent = true,
          italic_comments = true,
          hide_fillchars = true,
          terminal_colors = false,
          cache = true,
          borderless_telescope = false,
      })
  end,
}

image

it works only I set cache = false, but there was spend more time to start lazyvim

@github-actions github-actions bot removed waiting for op This issue is waiting for a response from the original poster labels Nov 4, 2024
@scottmckendry
Copy link
Owner

Can you try setting cache = false so the correct highlights are shown? Once the highlights are showing correctly, run :CyberdreamBuildCache.

This should fix the problem 🙂

@scottmckendry scottmckendry added the waiting for op This issue is waiting for a response from the original poster label Nov 5, 2024
@shouyierban
Copy link
Author

Can you try setting cache = false so the correct highlights are shown? Once the highlights are showing correctly, run :CyberdreamBuildCache.

This should fix the problem 🙂

I have tryed in this way, but still no work.
In lieu of that, after I manually modified the cache file and added the following, it displays properly.

{
  "TelescopeBorder": {
      "bg": "NONE"
  },
  "NeoTreeNormal": {
      "bg": "NONE"
  },
  "NeoTreeNormalNC": {
      "bg": "NONE"
  },
  "NeoTreeFileName": {
      "fg": "#ffffff"
  },
  "WhichKeyBorder": {
      "bg": "NONE"
  },
  "WhichKeyNormal": {
      "bg": "NONE"
  },
}

@github-actions github-actions bot removed the waiting for op This issue is waiting for a response from the original poster label Nov 6, 2024
@Yeastiest
Copy link

Is there any way to make telescope completely transparent? When I'm not using any colourscheme and it defaults to my terminal scheme, telescope is transparent, but when using cyberdream and the config above, as well as setting telescope options like set_hl, it still isnt transparent.

@scottmckendry
Copy link
Owner

@Yeastiest try borderless_telescope = false in your config. Probably not the best setting name looking back 😀

@Yeastiest
Copy link

Yeastiest commented Nov 20, 2024

@scottmckendry Alright thanks, besides that though I just wanna check, is having transparent telescope, nvim, neotree and all the others at the same time actually possible? Because that’s my end goal.

@Yeastiest
Copy link

Setting Telescope to bordered does work! Thanks a lot for the quick help

@github-actions github-actions bot linked a pull request Nov 19, 2024 that will close this issue
@scottmckendry
Copy link
Owner

Hey @shouyierban, can you let me know if the latest commit on main resolves the original issue you reported? The cache option should now handle changes to the config after exiting Neovim the second time.

@scottmckendry scottmckendry added the waiting for op This issue is waiting for a response from the original poster label Nov 23, 2024
@shouyierban
Copy link
Author

Hey @shouyierban, can you let me know if the latest commit on main resolves the original issue you reported? The cache option should now handle changes to the config after exiting Neovim the second time.

Hi @scottmckendry , I have updated today. Unfortunately, it dose still not work like before, and I have checked cache file, some configuration iterms still needs to be added manually.

"NeoTreeNormal": {
      "bg": "NONE"
  },
  "NeoTreeNormalNC": {
      "bg": "NONE"
  },
  "NeoTreeFileName": {
      "fg": "#ffffff"
  },
  "WhichKeyBorder": {
      "bg": "NONE"
  },
  "WhichKeyNormal": {
      "bg": "NONE"
  }, 
  "TelescopeNormal": {
      "bg": "NONE"
  }

@github-actions github-actions bot removed the waiting for op This issue is waiting for a response from the original poster label Nov 25, 2024
scottmckendry added a commit that referenced this issue Nov 25, 2024
to help with changing colorschemes within the same session where these
are already defined.
related #147
@scottmckendry
Copy link
Owner

Is it possible you're loading another colorscheme before cyberdream? The background colour #1e2131 in your screenshot isn't defined anywhere in the code base, so it must be getting set by another plugin somehow.

It has highlighted that both the whichkey and telescope extensions were missing some defaults, so those have been added now.

I don't have an extension for neotree in cyberdream yet, but will look to add support soon. In the meantime, I'd recommend reviewing your config for any other plugins that could be setting these highlights 🙂

@shouyierban
Copy link
Author

Is it possible you're loading another colorscheme before cyberdream? The background colour #1e2131 in your screenshot isn't defined anywhere in the code base, so it must be getting set by another plugin somehow.

It has highlighted that both the whichkey and telescope extensions were missing some defaults, so those have been added now.

I don't have an extension for neotree in cyberdream yet, but will look to add support soon. In the meantime, I'd recommend reviewing your config for any other plugins that could be setting these highlights 🙂

Hi @scottmckendry , good news, it works now! thank you for your nice job, and Looking forward to neotree joining,there will be a perfect theme.
By the way, is it possible to make the autocomplete window of blinkcmp to transparent? the documentation window is transparent now. I'm not sure if this is a theme issue or a plugin issue of blink-cmp.
Quicker_20241126_105523

@scottmckendry
Copy link
Owner

Great! glad to hear. And thank you for the kind words!

is it possible to make the autocomplete window of blinkcmp to transparent?

Hmm, I don't have an answer to that one. blink.cmp is working fine in my case:

image

Can you tell me what the output of :hi BlinkCmpMenu is? It should link to Pmenu which, in turn, should have a transparent background. Unless you have that group overridden somewhere else?

You could also try overriding BlinkCmpMenu in your config, like you did for the other groups to see if that makes any difference.

Btw I saw your issue in blink.cmp - I don't think this is an issue with the plugin itself. I'm one of the contributors on that project and have been using it with cyberdream for ages with no problem.

@scottmckendry
Copy link
Owner

Actually, I can replicate this if I set winblend = 1 in blink.cmp's setup:

image

removing the winblend option entirely fixes this for me - maybe that is the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants