do not set VERSION env var in Fedora Container files #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer use this variable and it seems to be causing some problems for some use-cases.
|
[test] |
|
Small (big in the context of the reported bug) issue, rebuilding the Fedora 3.1 container with this PR gives other VERSION: This is the version of the actual Fedora of the container, compared with info from /etc/os-release. In context of Rails, this will also completely revert all DB migrations as it seems rails is doing numerical compare and 37 is less than any YYYYMMDD formatted date "number". To fix the issue it seems we need to unset the env variable completely. Which might be the reason why the VERSION was set in the first place. |
|
@jackorp Good catch. I also vote for unsetting the variable entirely in this case. I will adjust this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer use this variable and it seems to be causing some problems for some use-cases.
Resolves: #530
@jackorp PTAL.