Skip to content
This repository has been archived by the owner on Dec 31, 2021. It is now read-only.

Text spread over too much horizontal space #68

Closed
peterbell10 opened this issue Nov 29, 2019 · 6 comments · Fixed by #73
Closed

Text spread over too much horizontal space #68

peterbell10 opened this issue Nov 29, 2019 · 6 comments · Fixed by #73
Labels
good first issue Good for newcomers

Comments

@peterbell10
Copy link
Member

Viewing the website on a 1440p monitor with firefox maximised, the text is spread out over too much horizontal space making it awkward to read.

scipy_sphinx_theme

Compare this to readthedocs' theme which limits the maximum width, keeping content closer together and easier to read (although I would prefer if everything was centred)
readthedocs

@Shekharrajak
Copy link
Member

Thanks for sharing the screenshot. Yes! It would be better if we make specific maximum fixed width for body content. Previously I was focusing on how to use the whole width to display the content.

@Shekharrajak Shekharrajak added the good first issue Good for newcomers label Nov 30, 2019
@fuglede
Copy link

fuglede commented Dec 3, 2019

Note that this (or at least something equivalent or very similar) is the first half of #58 as well, but that one has been marked as fixed.

@Shekharrajak
Copy link
Member

Max width is set: #73

Screenshot 2020-01-12 at 12 56 02 PM

@Shekharrajak
Copy link
Member

@fuglede can you please review and check the demo url: https://pr-73-scipy-sphinx-theme-v2.surge.sh/ for the PR #73

@fuglede
Copy link

fuglede commented Jan 17, 2020

Sure. I think it's much better! One thing that did strike me was that the blue side bar feels a bit "floaty", but I'm sure I'm just biased by how Read The Docs normally looks, and how it's left-aligned by default.

@Shekharrajak
Copy link
Member

Thanks for the review and comment @fuglede ! The base theme is Read The Doc and it is customized to fulfill the NumPy Doc requirement. I am closing this now.
Feel free to open it if you want to discuss anything else.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants